search

NREL / OpenStudio-measure-tester-gem

Other
3 stars 0 forks source link

Update rubocop #57

Closed tijcolem closed 3 years ago

tijcolem commented 3 years ago

fix #56

Updates to latest available version of rubocop. The new version requires an updated style v4 which has been uploaded to s3.

There were only a couple of minor changes from 0.54 to 1.1.5 as far the new rules are concerned.

1 ) The Lint/HandleExceptions cop has been renamed to Lint/SuppressedException.

2 ) The performance cop rules are now ran by a different gem called rubocop-performance which is now included in the gemspec.

Note runocop versions > 0.8.2 does not use jaro winkler which was problematic with the OpenStudio SDK due to the native ext component.

tijcolem commented 3 years ago

I noticed in the build logs that the version of ruby git gem 1.6.1 was throwing warning: Using the last argument as keyword parameters is deprecated and polluting the logs. I updated to the latest gem v1.8.1 and the warning is now gone.

tijcolem commented 3 years ago

@nllong I bumped the version to 0.3.1 and this is ready to merge. I tested with SDK installer using this gem and did a simple test and rubocop ran smoothly. As for the version bump....all gems that currently depend on openStudio-measure-tester that declare using pessimistic operator 'openstudio_measure_tester', '~> 0.3.0' and also have the .rubocop.yml with the s3 link ref will need to get updated. We could bump to 0.4.0 to avoid this but I think the plan is to update all gems that depend on measure-tester anyway so that is probably unnecessary.