search

NREL / OpenStudio-measure-tester-gem

Other
3 stars 0 forks source link

pin parser dependency #66

Closed kflemin closed 1 year ago

kflemin commented 1 year ago

the parser dependency, required by rubocop, has a new dependency named 'racc'. this has native extensions and is breaking the openstudio bundler workflow. Pinning the parser dependency to 3.2.2.2 fixes this issue.

jmarrec commented 6 months ago

@kflemin I just came to the same conclusion, cf https://github.com/NREL/OpenStudio/issues/5091

Could you release a new version with this PR/Commit.?

kflemin commented 6 months ago

@jmarrec done!

jmarrec commented 6 months ago

Thank you @kflemin . Seems like I still run into trouble trying to consume other gems that depend on things that transitevely require racc (via a dependency on rubyXL or Nokogiri) but that's one less thing to worry about.

We'll probably need to figure out what's the matter with racc...

kflemin commented 6 months ago

maybe it needs to get added here since it now has a native extension dependency: https://github.com/NREL/openstudio-gems/blob/develop/Gemfile#L24 ?

jmarrec commented 6 months ago

Duh. Of course that's the issue, I don't know how I missed it. Thanks a ton @kflemin! I'll need to do that and init it properly in the CLI.