search

NREL / OpenStudio-measure-tester-gem

Other
3 stars 0 forks source link

Symbol / String confusion for hash for minitest #78

Open jmarrec opened 4 months ago

jmarrec commented 4 months ago

bundle exec openstudio:rubocop

NoMethodError: undefined method `>' for nil:NilClass
/home/julien/Software/Others/openstudio_gems/OpenStudio-measure-tester-gem/lib/openstudio_measure_tester/openstudio_testing_result.rb:163:in `exit_code'
/home/julien/Software/Others/openstudio_gems/OpenStudio-measure-tester-gem/lib/openstudio_measure_tester/runner.rb:110:in `post_process_results'
/home/julien/Software/Others/openstudio_gems/OpenStudio-measure-tester-gem/lib/openstudio_measure_tester/runner.rb:176:in `run_rubocop'
/home/julien/Software/Others/openstudio_gems/OpenStudio-measure-tester-gem/lib/openstudio_measure_tester/rake_task.rb:45:in `block (3 levels) in setup_subtasks'
/home/julien/Software/Others/openstudio_gems/openstudio-bem-to-surrogate-gem/.bundle/ruby/2.7.0/gems/rake-13.2.1/exe/rake:27:in `<top (required)>
jmarrec commented 4 months ago

https://github.com/NREL/OpenStudio-measure-tester-gem/blob/14659ef904019789f651a890bc56d2324d725805/lib/openstudio_measure_tester/openstudio_testing_result.rb#L163

When I reach that code, I have 'total_failures' (String) as a key.

Note that I'm only running the rubocop, but I did have the minitest folder from a previous run.

Works:

rm -Rf test_results
bundle exec openstudio:rubocop
bundle exec openstudio:rubocop

Crashes:

rm -Rf test_results
bundle exec openstudio:all
bundle exec openstudio:rubocop
jmarrec commented 4 months ago

This is the only case where JSON.parse is used with "symbolize_names: true" : https://github.com/NREL/OpenStudio-measure-tester-gem/blob/14659ef904019789f651a890bc56d2324d725805/lib/openstudio_measure_tester/minitest_result.rb#L44