NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
501 stars 191 forks source link

Realign IDD for CoolingTower:SingleSpeed with E+ IDD #3650

Open kbenne opened 5 years ago

kbenne commented 5 years ago

The best way to handle this and all name changes is to add a synonym method and mark the old one deprecated. I think no change is good enough for this one though. Need to at least update the idd translator but that is probably already done if the code is compiling

jmarrec commented 5 years ago

Cooling:Tower:SingleSpeed is falling pretty out of sync with the E+ Idd.

I think it would be good to realign the IDD with E+, I don't think it's critical for this release. I would actually consider doing it for 3.0.0 and just break the API (I would still write VersionTranslator rules to maintain forward compatibility in models of course).

jmarrec commented 5 years ago

Saving some progress in https://github.com/jmarrec/OpenStudio/tree/3650_Realign_CoolingTowerSingleSpeed and removing the 2.9.0 milestone from this one + re-titling.