search

NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
505 stars 192 forks source link

CoilWaterHeaterDesuperheater: Issue Error in ForwardTranslator if Heat Reclaim Efficiency is out of bounds #3666

Closed jmarrec closed 2 years ago

jmarrec commented 5 years ago

https://github.com/NREL/OpenStudio/blob/d6d7665b56030fb20146a096f7366ee1141d4d24/openstudiocore/src/model/CoilWaterHeatingDesuperheater.cpp#L544

E+ will throw with this default.

   ** Severe  ** Coil:WaterHeating:Desuperheater = COIL WATER HEATING DESUPERHEATER 1: Rated Heat Reclaim Recovery Efficiency must be > 0.0 and <= 0.3, Rated Heat Reclaim Recovery Efficiency = 0.800
   ** Severe  ** Coil:WaterHeating:Desuperheater = COIL WATER HEATING DESUPERHEATER 2: Rated Heat Reclaim Recovery Efficiency must be > 0.0 and <= 0.3, Rated Heat Reclaim Recovery Efficiency = 0.800
   **  Fatal  ** Errors found in getting Coil:WaterHeating:Desuperheater input. Preceding condition causes termination.
   ...Summary of Errors that led to program termination:
   ..... Reference severe error count=2
   ..... Last severe error=Coil:WaterHeating:Desuperheater = COIL WATER HEATING DESUPERHEATER 2: Rated Heat Reclaim Recovery Efficiency must be > 0.0 and <= 0.3, Rated Heat Reclaim Recovery Efficiency = 0.800

cf: https://github.com/NREL/OpenStudio-resources/pull/71#issuecomment-528782153

jmarrec commented 5 years ago

This is only the case if it's NOT a refrigeration equipment:

https://github.com/jmarrec/EnergyPlus/blob/2f2115f490c523cfc2c22e506a795b48799b4562/src/EnergyPlus/WaterThermalTanks.cc#L1372:L1398

This checks has been there for at least 6 years in E+. Probably should issue an Error in the FT... but not much else we can do. Re-titling and labeling.