search

NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
499 stars 190 forks source link

Update to EnergyPlus 9.6.0 #4405

Closed joseph-robertson closed 3 years ago

joseph-robertson commented 3 years ago

Enhancement Request

Once v9.6.0-IOFreeze is released, we should update to it.

Detailed Description

https://github.com/NREL/EnergyPlus/blob/develop/src/Transition/InputRulesFiles/Rules9-5-0-to-9-6-0.md

Major changes

New additions

Minor stuff

Other

jmarrec commented 3 years ago

Side note: This is missing since at least 8.5.0 in our ProposedEnergy+.idd, due to the fact that it's placed AFTER some extensible fields... I would leave it as missing.

Coil:Cooling:DX:MultiSpeed,

[...] A37; \field Zone Name for Condenser Placement \type object-list \object-list ZoneNames \note This input field is name of a conditioned or unconditioned zone where the secondary \note coil (condenser) of DX system or a heat pump is to be placed. This is an optional \note input field specified only when user desires to reject the condenser heat into a \note zone. The heat rejected is modelled as internal sensible heat gain of the zone.

joseph-robertson commented 3 years ago

Oops. So I added PythonPlugin:Instance to the list, but that idd change was already there? I will remove it from the list above.

joseph-robertson commented 3 years ago

epJSONFixture test failures:

        "UtilityCost:Charge:Simple 16": {
            "category_variable_name": "Taxes",
            "cost_per_unit_value_or_variable_name": 0.08,
            "season": "Annual",
            "source_variable": "SubTotal",
            "tariff_name": "PSI_CS_CommercialElectricService",
            "utility_cost_charge_simple_name": "TaxofeightPercent"
        },
        "UtilityCost:Charge:Simple 17": {
            "category_variable_name": "EnergyCharges",
            "cost_per_unit_value_or_variable_name": "IN_MonthlyGasRates", <--- [utilities.idf.IdfObject] <1> Could not convert 'IN_MonthlyGasRates' to double
            "season": "Annual",
            "source_variable": "totalEnergy",
            "tariff_name": "IN_EIAMonthlyRateGas",
            "utility_cost_charge_simple_name": "MonthlyRateGasCharge"
        },
shorowit commented 3 years ago

I'm getting an error using OpenStudio-3.3.0-alpha+e22f7b09f0-Ubuntu-20.04, which is using E+ 9.6 rc2. It looks like the generated_files that OpenStudio produces are not compatible with EnergyPlus because the file extensions are stripped. EnergyPlus error:

Program Version,EnergyPlus, Version 9.6.0-9779acae72, YMD=2021.09.22 14:53,
   ** Warning ** Timestep: Requested number (1) is less than the suggested minimum of 4.
   **   ~~~   ** Please see entry for Timestep in Input/Output Reference for discussion of considerations.
   ** Severe  ** ProcessScheduleInput: Schedule:File="LIGHTING_INTERIOR", File Name="/mnt/c/git/openstudio-hpxml-os330/workflow/generated_files/schedules20210922-754-ja1s6g" has an unknown file extension and cannot be read by this program.
   **  Fatal  ** Program terminates due to previous condition.
   ...Summary of Errors that led to program termination:
   ..... Reference severe error count=1
   ..... Last severe error=ProcessScheduleInput: Schedule:File="LIGHTING_INTERIOR", File Name="/mnt/c/git/openstudio-hpxml-os330/workflow/generated_files/schedules20210922-754-ja1s6g" has an unknown file extension and cannot be read by this program.
   ************* Warning:  Node connection errors not checked - most system input has not been read (see previous warning).
   ************* Fatal error -- final processing.  Program exited before simulations began.  See previous error messages.
   ************* EnergyPlus Warmup Error Summary. During Warmup: 0 Warning; 0 Severe Errors.
   ************* EnergyPlus Sizing Error Summary. During Sizing: 0 Warning; 0 Severe Errors.
   ************* EnergyPlus Terminated--Fatal Error Detected. 1 Warning; 1 Severe Errors; Elapsed Time=00hr 00min  0.13sec

The file provided to OS was "stochastic.csv", which got renamed to "generated_files/schedules20210922-754-ja1s6g".

EDIT: I was wrong, Our workflow was providing a filename of "schedules20210922-754-ja1s6g" to OpenStudio. But E+ 9.5 didn't complain about this while E+ 9.6 does. We can resolve the issue on our end; it's unclear whether OpenStudio needs a change to help the user.

jmarrec commented 3 years ago

@shorowit Do you have a MCVE somewhere so I could try to reproduce without having to recreate from scratch?

shorowit commented 3 years ago

@jmarrec You can reproduce the issue by checking out this code: https://github.com/NREL/OpenStudio-HPXML/tree/6990f847cf3f15ca527f68a736d556f509bd9522

Then run openstudio run -w workflow/template-stochastic-schedules.osw. You'll find the above error in the workflow/run/eplusout.err file. Note that it occurs because we were providing a temp filename without an extension to OpenStudio::Model::ExternalFile::getExternalFile. As previously mentioned, E+ 9.5 was okay with this but E+ 9.6 now throws an error. We fixed this by preserving the file extension in the temp file, but maybe OpenStudio could be more helpful in preventing this error.