NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
505 stars 192 forks source link

OpenStudio exported gbXML 'exposedToSun' attribute not written #4559

Closed jpstaub closed 2 years ago

jpstaub commented 2 years ago

Issue overview

On OpenStudio forward translation to gbXML the 'exposedToSun' attribute is not written to exterior surface types.

Current Behavior

Instead of writing the 'exposedToSun' attribute for exterior surface types no attribute is written by OpenStudio forward translation to gbXML.

Expected Behavior

The 'exposedToSun' attribute should be written for exterior surface types per the gbXML schema.

Steps to Reproduce

  1. Set a representative wall with an 'Outdoor' boundary condition.
  2. Export to gbXML.
  3. View gbXML with text editor and observe 'exposedToSun' attribute not set.

Details

Please click here for additional details posted to Unmet Hours.

Environment

Operating system: Windows 10 Openstudio Application: v1.3.1 (SDK version 3.3.0)

Context

Severity of not writing the 'exposedToSun' attribute for exterior surface types is unknown at this time. The issue was discovered while reviewing gbXML files for consistency using the Spider gbXML Viewer.

The gbXML schema suggests the 'exposedToSun' attribute has importance in that it separates exterior surfaces that are exposed to the sun from those that are not.

Thank you for your time and consideration of this issue.

-Jake Staub

macumber commented 2 years ago

It looks like that attribute isn't being set in ForwardTranslator::translateSurface. I'm not sure what impact it has if it is not set, apparently it would default to true.

jpstaub commented 2 years ago

Since my use of gbXML is limited to Spider Viewer and Trane TRACE700 I am not qualified to assess impact across the wider gbXML community. I have requested that gbXML.org comment on behalf of the community.

As far as Spider Viewer is concerned, the absence of the attribute prevents filtering for 'exposedToSun' faces which increases level of difficulty of the gbXML quality assurance process.

I have not had the opportunity to characterize severity of impact on TRACE700 analysis results.