NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
503 stars 192 forks source link

Wrap ZoneHVAC:RefrigerationChillerSet #4921

Closed eringold closed 1 year ago

eringold commented 1 year ago

Enhancement Request

OpenStudio already wraps Refrigeration:AirChiller, but it is not much use without the zone equipment to reference it. ZoneHVAC:RefrigerationChillerSet is needed to model refrigerated warehouses.

https://bigladdersoftware.com/epx/docs/23-1/input-output-reference/group-zone-forced-air-units.html#zonehvacrefrigerationchillerset

https://github.com/NREL/EnergyPlus/blob/develop/testfiles/RefrigeratedWarehouse.idf

jmarrec commented 1 year ago

RefrigerationAirChiller is used on the RefrigerationSystem and RefrigerationSecondarySystem https://bigladdersoftware.com/epx/docs/23-1/input-output-reference/group-refrigeration.html#field-refrigerated-case-or-walkin-or-caseandwalkinlist-name and can apparently be used without this object.

Just saying, not saying ZoneHVAC:RefrigerationChillerSet does not fit a purpose and shouldn't be wrapped.

It seems to be a rather simple object. I don't like the E+ IDD though. Seems that it should be a proper ZoneHVAC component, defining the Inlet / outlet nodes, and being part of the ZoneHVACEquipment etc, but apparently it's more of a space load...

-  A3  , \field Zone Name
        \note This must be a controlled zone and appear in a ZoneHVAC:EquipmentConnections object.
        \type object-list
        \object-list ZoneNames
  A4 ,  \field Air Inlet Node Name
        \type node
-        \note Not used - reserved for future use
        \note Name of the zone exhaust node (see Node) from which the refrigeration chiller
        \note draws its indoor air.
        \note This should be one of the zone exhaust nodes for the zone cooled by the chiller set.
  A5 ,  \field Air Outlet Node Name
        \type node
-        \note Not used - reserved for future use
        \note The name of the node where the chiller coil sends its outlet air,
        \note which must be one of the inlet air nodes for the zone which is being cooled.
jmarrec commented 1 year ago

I wish this was documented a bit better, but this is actually already handled. Just do RefrigerationAirChiller::addToThermalZone (in the order you need it), and the FT takes care of it

https://github.com/NREL/OpenStudio/blob/79e9fe35a4d7dddd7f93f3c8c2e9b2d2e7d94dc7/src/energyplus/ForwardTranslator/ForwardTranslateZoneHVACEquipmentList.cpp#L162-L166

jmarrec commented 1 year ago

Added a docstring explaining this in https://github.com/NREL/OpenStudio/commit/2af6123b91304e12060af360d0afb24083336a4c , this will show on the SDK documentation

eringold commented 1 year ago

thanks @jmarrec!