NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
501 stars 191 forks source link

Old materials OSC (< 0.7.4) cannot be loaded anymore #4994

Open jmarrec opened 1 year ago

jmarrec commented 1 year ago

Issue overview

Old components like Brick - Fired Clay - 4 in. - 130 lb/ft3 cannot be loaded anymore

Steps to Reproduce

get Brick - Fired Clay - 4 in. - 130 lb/ft3 from BCL.

Try to load it

$ openstudio -e "vt = OpenStudio::OSVersion::VersionTranslator.new; c = vt.loadComponent('Brick_Fired_Clay_4_in_130_lb_ft3.osc')"
[utilities.idf.IdfFile] <1> Could not parse a single valid object in file.
[openstudio.model.Component] <2> Cannot construct Component from IdfFile because the file contains 0 ComponentData objects.
[openstudio.osversion.VersionTranslator] <1> Could not translate component, because /Users/julien/Software/Others/OpenStudio/src/model/Component.cpp@186 : Cannot construct Component from IdfFile because the file contains 0 ComponentData objects.

Possible Solution

Issue (found from using a debugger) is the conjunction of what update_0_7_3_to_0_7_4 does and what I added here: https://github.com/NREL/OpenStudio/blob/de661404d2ed08ef38198bf28239d2c5d89173be/src/osversion/VersionTranslator.cpp#L524

Details

Environment

Some additional details about your environment for this issue (if relevant):

Context

Reported at https://unmethours.com/question/97118/the-material-downloaded-from-bcl-can-not-be-dropped-on-materials-tab/