Closed joseph-robertson closed 1 year ago
@joseph-robertson I made a couple of changes (disabling one round trip test mostly) and left a few notes that I think we do want to address, but this is good enough to get into RC1 anyways. Letting CI run on it, then we can merge if all green.
CI Results for bb8a9f37a55a8a08add74b10755960b2f3593aad:
Ubuntu 20.04:
Ubuntu 22.04:
Darwin:
Windows:
Code Coverage:
Pull request overview
Addresses #4966.
Checklist:
XMLValidator::gbxmlValidator()
ForwardTranslator::translateModel()
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.