Fix #5045 - Fix typo in OSArgument::toJSON + improve reporting when README ERB generation fails

jmarrec commented 11 months ago

Pull request overview

Fixes #5045

After this PR, in case the README.md.erb fails to ERB render

Failed to Render ERB file: NoMethodError: undefined method `join' for nil:NilClass
Traceback:
(erb):25:in `block in get_binding'
(erb):13:in `each'
(erb):13:in `get_binding'
:/ruby/2.7.0/erb.rb:905:in `eval'
:/ruby/2.7.0/erb.rb:905:in `result'
eval:210:in `renderFile'
Failed to generate the README.md via ERB

I also added a warning in case the ReportingMeasure arguments takes no argument

Reporting Measure at '<path/to/measure.rb>' is using the old format where the 'arguments' method does not take model.  Please consider updating this to `def arguments(model)`.

Pull Request Author

[ ] Model API Changes / Additions
[ ] Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
[ ] Model API methods are tested (in src/model/test)
[ ] EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
[ ] If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
[ ] If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
[ ] Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
[ ] All new and existing tests passes
[ ] If methods have been deprecated, update rest of code to use the new methods

Labels:

[ ] If change to an IDD file, add the label IDDChange
[ ] If breaking existing API, add the label APIChange
[ ] If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

[ ] Perform a Code Review on GitHub
[ ] Code Style, strip trailing whitespace, etc.
[ ] All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
[ ] Labeling is ok
[ ] If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
[ ] If feature, test running new feature, try creative ways to break it
[ ] CI status: all green or justified