Closed joseph-robertson closed 5 months ago
@shorowit pointed out that it's not always appropriate to use idf testfile values. @DavidGoldwasser pointed out that there may be helpful curve information on other DX coil objects.
Make all non curve fields required so that, even when Mode=No, the fields are pre-populated in case Mode is switched to Yes?
I'm kinda torn on this one. There are three options:
bool validityCheck()
method, and call that at the beginning of the FT or something similar (this is what's done for the ElectricLoadCenterDistribution, since dependending on some choice fields you must have an inverter or not for eg). Then issue a loud warn, and do not translate it.
Worth noting that I doubt this object will be commonly used by people, so factor that in.
@kbenne Can you please advise here?
My vote is leave the curves as optionals (so either bullet 2 or 3); it doesn't look the one testfile on the E+ repo with Coil:Cooling:DX:SingleSpeed:ThermalStorage has all the curve fields populated, so what would we set them to?
I don't see where ElectricLoadCenterDistribution's validityCheck
even gets called?
I don't see where ElectricLoadCenterDistribution's
validityCheck
even gets called?
It isn't, but it should.
@joseph-robertson One failing test
1056: [ RUN ] ModelFixture.CoilCoolingDXSingleSpeedThermalStorage_clone
1056: /srv/jenkins/openstudio/docker-volumes/ubuntu-2004/src/model/test/CoilCoolingDXSingleSpeedThermalStorage_GTest.cpp:992: Failure
1056: Expected equality of these values:
1056: 0
1056: model.getModelObjects<Curve>().size()
1056: Which is: 3
1056: /srv/jenkins/openstudio/docker-volumes/ubuntu-2004/src/model/test/CoilCoolingDXSingleSpeedThermalStorage_GTest.cpp:993: Failure
1056: Expected equality of these values:
1056: 0
1056: model.getConcreteModelObjects<CurveBiquadratic>().size()
1056: Which is: 1
1056: /srv/jenkins/openstudio/docker-volumes/ubuntu-2004/src/model/test/CoilCoolingDXSingleSpeedThermalStorage_GTest.cpp:994: Failure
1056: Expected equality of these values:
1056: 0
1056: model.getConcreteModelObjects<CurveQuadratic>().size()
1056: Which is: 1
1056: /srv/jenkins/openstudio/docker-volumes/ubuntu-2004/src/model/test/CoilCoolingDXSingleSpeedThermalStorage_GTest.cpp:995: Failure
1056: Expected equality of these values:
1056: 0
1056: model.getConcreteModelObjects<CurveTriquadratic>().size()
1056: Which is: 1
1056: [ FAILED ] ModelFixture.CoilCoolingDXSingleSpeedThermalStorage_clone (10 ms)
1056: [----------] 1 test from ModelFixture (11 ms total)
1056:
1056: [----------] Global test environment tear-down
1056: [==========] 1 test from 1 test suite ran. (11 ms total)
1056: [ PASSED ] 0 tests.
1056: [ FAILED ] 1 test, listed below:
1056: [ FAILED ] ModelFixture.CoilCoolingDXSingleSpeedThermalStorage_clone
CI Results for faffcfd8b8a99621ca57752e0a741299701502d0:
Ubuntu 20.04:
Ubuntu 22.04:
Darwin:
Windows:
Code Coverage:
Pull request overview
RetailPackagedTESCoil.idf
? Or a mix of the idf values and idd defaults?RetailPackagedTESCoil.idf
.Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.