NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
494 stars 188 forks source link

ControllerMechanicalVentilation is missing options for the "System Outdoor Air Method" compared to E+ #5060

Open jmarrec opened 9 months ago

jmarrec commented 9 months ago

Enhancement Request

Missing these:

        \key IndoorAirQualityProcedureGenericContaminant
        \key IndoorAirQualityProcedureCombined
        \key ProportionalControlBasedOnDesignOARate

Additionally, it's time to remove "ProportionalControl", which has been there as a backward compatible mapping to "ProportionalControlBasedonOccupancySchedule" for at least 8 years: https://github.com/NREL/OpenStudio/commit/b1b6b6d9a56a674dcdadc97a8b67393c3c188579

Detailed Description

OpenStudio

https://github.com/NREL/OpenStudio/blob/55040fb543628bcbeff73532d488d6ad8ba968ee/resources/model/OpenStudio.idd#L21445-L21453

       \key ZoneSum
       \key Standard62.1VentilationRateProcedure
       \key Standard62.1VentilationRateProcedureWithLimit
       \key IndoorAirQualityProcedure
       \key ProportionalControl    -> maps to ProportionalControlBasedonOccupancySchedule in FT
       \key ProportionalControlBasedOnOccupancySchedule
       \key ProportionalControlBasedOnDesignOccupancy

E+

   A4,  \field System Outdoor Air Method
        \type choice
        \key ZoneSum
        \key Standard62.1VentilationRateProcedure
        \key Standard62.1VentilationRateProcedureWithLimit
        \key IndoorAirQualityProcedure
        \key ProportionalControlBasedOnDesignOccupancy
        \key ProportionalControlBasedOnOccupancySchedule
        \key IndoorAirQualityProcedureGenericContaminant
        \key IndoorAirQualityProcedureCombined
        \key ProportionalControlBasedOnDesignOARate
        \default Standard62.1VentilationRateProcedure

Possible Implementation

Found during review of a PR to OSApp that tries to align them: https://github.com/openstudiocoalition/OpenStudioApplication/pull/646#discussion_r1422211776