NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
486 stars 186 forks source link

WorkflowJSON constantly calling setMeasureTypes (in the Ctor, in clone, in save, etc) #5083

Open brianlball opened 6 months ago

brianlball commented 6 months ago

ValidateXML getting called a lot.

This is from slack convo from Julien:

WorkflowJSON.cpp (https://github.com/NREL/OpenStudio/blob/1ce97f5651ff868500e4168aaa8e0a441559edce/src/utilities/filetypes/WorkflowJSON.cpp) for (const auto& step : m_steps) { if (step.optionalCastMeasureStep()) { boost::optionalBCLMeasure bclMeasure = getBCLMeasure(step.castMeasureStep()); https://github.com/[NREL/OpenStudio](https://github.com/NREL/OpenStudio)|NREL/OpenStudioNREL/OpenStudio | Added by GitHub 10:18 that in turns loads the BCLMeasure, which validates the XML...

I do not get this to the out.osw “stdout” key with 3.7.0 on unix at least, but it’s in the run.log

that constant loading the BCLMeasure has been here for 8 years. What changed is that there used to be no XMLValidator happening.