Closed joseph-robertson closed 4 months ago
On the "No" vs "Yes" default issue...
I tried running fan_on_off.rb on OpenStudio-resources, using both v3.7.0 and v3.8.0-alpha. The energy results change for both "No" and "Yes" (and are the same). So, something else must be accounting for the deviation. And not sure what to make of "No" and "Yes" having identical results.
Assuming CI builds fine after I resolved conflicts, we can do ahead and merge this one, it's good enough to go into the main IOFreeze branch, we can figure out the Yes / No EUI deviation later on.
CI Results for 5c31398f9fb02d55c8cd3a8931860974fc0ea9ea:
Ubuntu 20.04:
Ubuntu 22.04:
Darwin:
Windows:
Code Coverage:
Pull request overview
New "No Load Supply Air Flow Rate Control Set To Low Speed" field for the following objects:
ZoneHVAC:PackagedTerminalAirConditioner
ZoneHVAC:PackagedTerminalHeatPump
ZoneHVAC:WaterToAirHeatPump
AirLoopHVAC:UnitarySystem
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.