v24.1.0-IOFreeze: HeatExchangerAirToAirSensibleAndLatent

[joseph-robertson]

Pull request overview

Remove:

• Sensible Effectiveness at 75% Heating Air Flow
• Latent Effectiveness at 75% Heating Air Flow
• Sensible Effectiveness at 75% Cooling Air Flow
• LatentEffectiveness at 75% Cooling Air Flow

Add:

• Sensible Effectiveness of Heating Air Flow Curve Name
• Latent Effectiveness of Heating Air Flow Curve Name
• Sensible Effectiveness of Cooling Air Flow Curve Name
• Latent Effectiveness of Cooling Air Flow Curve Name

Questions:

• Do we want to support deprecated 75 methods? If so, seems like it would get tricky. They would need to operate on TableLookup objects, checking for existence, creating if not in existence, etc. I think even the 100 methods would need to modify the TableLookup objects...

Pull Request Author

• [ ] Model API Changes / Additions
• [ ] Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• [ ] Model API methods are tested (in src/model/test)
• [ ] EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• [ ] If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• [ ] If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• [ ] Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• [ ] All new and existing tests passes
• [ ] If methods have been deprecated, update rest of code to use the new methods

Labels:

• [ ] If change to an IDD file, add the label IDDChange
• [ ] If breaking existing API, add the label APIChange
• [ ] If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• [ ] Perform a Code Review on GitHub
• [ ] Code Style, strip trailing whitespace, etc.
• [ ] All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• [ ] Labeling is ok
• [ ] If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• [ ] If feature, test running new feature, try creative ways to break it
• [ ] CI status: all green or justified

[jmarrec]

Options:

• Remove backward compatibility altogether. This would require the SDD stuff to be updated... Is that an option @kbenne ?
• Implement backward compatibility manually. This requires a bit of code to do it right, I'm guessing I can do it in about 4 hours.
• Implement TableLookup_Impl::evaluate: this would ideally require using https://github.com/bigladder/btwxt like E+ does, but the packaging is problematic. It has submodules dependencies (google test, fmt and bigladder's courier) and therefore creating a conan recipe is quite problematic. Using CMAke's ExternalPackageAdd isn't really helping either since some of these dependencies we also do have and we don't want to mix up deps versions.

[ci-commercialbuildings]

CI Results for 8c9e74e2288e04f113e0e791d76d2435e7cb2545:

• Ubuntu 20.04:

• Ubuntu 22.04:

• Darwin:

  • OpenStudio-3.8.0+8c9e74e228-Darwin-x86_64.dmg
  • OpenStudio-3.8.0+8c9e74e228-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.8.0+8c9e74e228-Windows.exe
  • OpenStudio-3.8.0+8c9e74e228-Windows.tar.gz

• Code Coverage:

[jmarrec]

@joseph-robertson I made some changes, this is good enough to go into the main IO freeze branch

[mdahlhausen]

@joseph-robertson @jmarrec we may need to modify the work done in this PR. Some models made in OpenStudio are hitting a failure in EnergyPlus with the default curve set: https://github.com/NREL/EnergyPlus/issues/10464

[mdahlhausen]

update - issue is the default table from OpenStudio has a divide by zero. Need to change the OpenStudio default.