search

NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
486 stars 186 forks source link

Deprecate ElectricEquipmentITEAirCooledDefinition's "Watts per Zone Floor Area" and replace with "Watts per Space Floor Area" #5103

Closed jmarrec closed 4 months ago

jmarrec commented 4 months ago

Enhancement Request

Deprecate ElectricEquipmentITEAirCooledDefinition's "Watts per Zone Floor Area" and replace with "Watts per Space Floor Area"

Detailed Description

cf https://github.com/NREL/OpenStudio/issues/5090#issuecomment-1988079322

Possible Implementation

Straightforward.

jmarrec commented 4 months ago

The schedules should never have been optional, but defaulted to always on: https://github.com/NREL/OpenStudio/blob/c48911e514514a3cd218213b60e75c6dfa621670/src/model/ElectricEquipmentITEAirCooled.hpp#L52-L60

but this would be an API break now

jmarrec commented 4 months ago

Seems like the "Number of Units" field was omitted from the implementation. I think it's replaced by Multiplier to match other objects

jmarrec commented 4 months ago

All other SpaceLoadInstances use the same terminology powerPerFloorArea / getPowerPerFloorArea but this one doesn't, it uses wattsperZoneFloorArea

jmarrec commented 4 months ago

Setters don't clear the other field. setWattsperFloorArea should clear the Watts Per Unit one, and vice versa