Fix #5108 - quote call to ExpandObjects for paths with spaces

[jmarrec]

Pull request overview

• Fixes #5108
• Automated testing is too tricky to bother, but I did test before and after manually

ln -sf /Applications/EnergyPlus-23-2-0 "energy plus2320"
export ENERGYPLUS_EXE_PATH="$(pwd)/energy plus2320/energyplus"
openstudio run --style-stdout --show-stdout -w workflow.osw

Before:

sh: /Users/julien/Downloads/temp/5108/energy: No such file or directory
[openstudio.workflow.OSWorkflow] <Warn> ExpandObjects returned a non-zero exit code (32512).

After:

$ "/Users/julien/Downloads/temp/test os380fix/bin/openstudio" run --style-stdout --show-stdout -w workflow.osw

ExpandObjects Started.
No expanded file generated.
ExpandObjects Finished. Time:     0.014

Pull Request Author

• [ ] Model API Changes / Additions
• [ ] Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• [ ] Model API methods are tested (in src/model/test)
• [ ] EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• [ ] If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• [ ] If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• [ ] Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• [ ] All new and existing tests passes
• [ ] If methods have been deprecated, update rest of code to use the new methods

Labels:

• [ ] If change to an IDD file, add the label IDDChange
• [ ] If breaking existing API, add the label APIChange
• [ ] If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• [ ] Perform a Code Review on GitHub
• [ ] Code Style, strip trailing whitespace, etc.
• [ ] All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• [ ] Labeling is ok
• [ ] If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• [ ] If feature, test running new feature, try creative ways to break it
• [ ] CI status: all green or justified

[ci-commercialbuildings]

CI Results for 156fc098c5b355103cabeba2b3ffa5efad0e5750:

• Ubuntu 20.04:

  • OpenStudio-3.8.0+156fc098c5-Ubuntu-20.04-x86_64.deb
  • OpenStudio-3.8.0+156fc098c5-Ubuntu-20.04-x86_64.tar.gz

• Ubuntu 22.04:

  • OpenStudio-3.8.0+156fc098c5-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.8.0+156fc098c5-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

  • OpenStudio-3.8.0+156fc098c5-Darwin-x86_64.dmg
  • OpenStudio-3.8.0+156fc098c5-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.8.0+156fc098c5-Windows.exe
  • OpenStudio-3.8.0+156fc098c5-Windows.tar.gz

• Code Coverage:

[jmarrec]

@chriswmackey binary is above

[chriswmackey]

Thanks, @jmarrec . Clicking on the .exe doesn't seem to start the download for me. Is there something that I'm missing here?

[chriswmackey]

Nevermind. I think it was just a bothersome security feature in Chrome that was not letting my download executables from addresses that didn't start with https. I have the exe now.