Fix #1472 - Respect user's SimulationControl choices and move smart defaults to the modelObject

[jmarrec]

Pull request overview

• Fixes #1472

• We always respect a value that the user has picked
  • I don't care if this means that the E+ simulation will crash. It's going to be clear that's the problem
  • I do issue a Warning if the user has deliberately picked "No" but it looks like it should be enabled
• When defaulted, the smart default is in the model object itself

@kbenne does that make sense to you?

Pull Request Author

• [x] Model API Changes / Additions
• [x] Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• [x] Model API methods are tested (in src/model/test)
• [x] EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• [ ] If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• [ ] If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• [ ] Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• [ ] All new and existing tests passes
• [ ] If methods have been deprecated, update rest of code to use the new methods

Labels:

• [x] If change to an IDD file, add the label IDDChange
• [x] If breaking existing API, add the label APIChange
• [x] If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• [ ] Perform a Code Review on GitHub
• [ ] Code Style, strip trailing whitespace, etc.
• [ ] All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• [ ] Labeling is ok
• [ ] If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• [ ] If feature, test running new feature, try creative ways to break it
• [ ] CI status: all green or justified

[ci-commercialbuildings]

CI Results for 6374961bc55ff04b876e285c721d850ec5d63ca6:

• Ubuntu 20.04:

  • OpenStudio-3.8.0-beta+6374961bc5-Ubuntu-20.04-x86_64.deb
  • OpenStudio-3.8.0-beta+6374961bc5-Ubuntu-20.04-x86_64.tar.gz

• Ubuntu 22.04:

  • OpenStudio-3.8.0-beta+6374961bc5-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.8.0-beta+6374961bc5-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

  • OpenStudio-3.8.0-beta+6374961bc5-Darwin-x86_64.dmg
  • OpenStudio-3.8.0-beta+6374961bc5-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.8.0-beta+6374961bc5-Windows.exe
  • OpenStudio-3.8.0-beta+6374961bc5-Windows.tar.gz

• Code Coverage:

[kbenne]

@jmarrec I like the principles that you laid out and I expect that most other people will too. I think this is a good pattern to use as much as we can.

• We always respect a value that the user has picked, even if the E+ simulation will crash.
• Issue a Warning if the user has deliberately picked a value that will result in EnergyPlus crashing.
• When defaulted, the smart default is in the model object itself