#5121 - Extensible Groups problems in ModelObject/WorkspaceObject

[jmarrec]

Pull request overview

• Fix for #5121

Seems like the problem is that ModelObject, via WorkspaceObject resolves any handle field to the name the target, and during eraseExtensibleGroup, that goes nuclear, and if the Schedule is named like the object, and the schedule is found first in the workspace, then you end up with the Schedule being on the ZoneHVACEquipmentList...

Pull Request Author

• [ ] Model API Changes / Additions
• [ ] Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• [ ] Model API methods are tested (in src/model/test)
• [ ] EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• [ ] If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• [ ] If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• [ ] Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• [ ] All new and existing tests passes
• [ ] If methods have been deprecated, update rest of code to use the new methods

Labels:

• [ ] If change to an IDD file, add the label IDDChange
• [ ] If breaking existing API, add the label APIChange
• [ ] If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• [ ] Perform a Code Review on GitHub
• [ ] Code Style, strip trailing whitespace, etc.
• [ ] All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• [ ] Labeling is ok
• [ ] If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• [ ] If feature, test running new feature, try creative ways to break it
• [ ] CI status: all green or justified

[jmarrec]

Note: the windows build is bricked because it built another PR (the schedule change from Joe).

The perf tests is bricked because it's missing a precondition (@wenyikuang), and is failing on all PRs.

[ci-commercialbuildings]

CI Results for 0996673a1cf5cd4fa255fa8b01ba7e87a38eb107:

• Ubuntu 20.04:

• Ubuntu 22.04:

• Darwin:

  • OpenStudio-3.8.0-beta+0996673a1c-Darwin-x86_64.dmg
  • OpenStudio-3.8.0-beta+0996673a1c-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.8.0-beta+0996673a1c-Windows.exe
  • OpenStudio-3.8.0-beta+0996673a1c-Windows.tar.gz

• Code Coverage: