search

NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
484 stars 185 forks source link

EPWDesignCondition getters should return boost::optional #5132

Open joseph-robertson opened 3 months ago

joseph-robertson commented 3 months ago

Issue overview

Missing design condition (double?) fields in the header of the EPW file return a zero, and they shouldn't.

See https://github.com/NREL/OpenStudio/pull/3086 for the original implementation.

Current Behavior

Expected Behavior

Steps to Reproduce

1. 2. 3. 4.

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

Context

joseph-robertson commented 3 months ago

Note that 2021 ASHRAE Handbook design conditions contain a new WSF element just before the cooling design conditions. Does this mean that the current version of the SDK's epw_file.designConditions doesn't support 2021 design condition headers?

See https://github.com/NREL/resstock/issues/1137 for some context.

shorowit commented 3 months ago

That's not part of the EPW spec, right? So it shouldn't be included in any EPW files.