Closed macumber closed 2 months ago
This does not affect the classic
CLI.
Aren't TODOs a great way to remind you to finish something and never actually do it? https://github.com/NREL/OpenStudio/blob/b8093180dc61a47935c2fcf067e4cd8bb0fd8a28/src/workflow/ApplyMeasure.cpp#L42
Edit: hem, I thought I did it though here: https://github.com/NREL/OpenStudio/blob/b8093180dc61a47935c2fcf067e4cd8bb0fd8a28/src/workflow/ApplyMeasure.cpp#L78-L89
Ok yeah, I need to prepareForMeasureRun before I can set the step Result and increment the step
https://github.com/NREL/OpenStudio/commit/c6ff09ce86a4b1d618737ce3ca21cef8c5ccc746 fixes it. I tested locally.
Thanks @jmarrec !
Issue overview
When adding measures to a workflow, there is a special SKIP argument that can be used to skip running a measure. Setting SKIP to true results in step_values being added to the wrong measure in the out.osw file for subsequent measures in the workflow.
Current Behavior
step_values are associated with the wrong measure in out.osw when a measure is skipped
Expected Behavior
step_values should be associated with the correct measure in out.osw when a measure is skipped
Steps to Reproduce
[openstudio.measure.OSRunner] <Error> Not prepared for step
is shown when measure is skippedPossible Solution
Details
Environment
Some additional details about your environment for this issue (if relevant):
Context
Parsing of results in out.osw file broken for test suite