Fix #5162 - Capture `exit` from Ruby

jmarrec commented 5 months ago

Pull request overview

Note: this does fix the Minitest return value, even with the minitest/autorun using at_exit

[ ] Model API Changes / Additions
[ ] Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
[ ] Model API methods are tested (in src/model/test)
[ ] EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
[ ] If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
[ ] If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
[ ] Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
[ ] All new and existing tests passes
[ ] If methods have been deprecated, update rest of code to use the new methods

Labels:

[ ] If change to an IDD file, add the label IDDChange
[ ] If breaking existing API, add the label APIChange
[ ] If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

This will not be exhaustively relevant to every PR.

[ ] Perform a Code Review on GitHub
[ ] Code Style, strip trailing whitespace, etc.
[ ] All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
[ ] Labeling is ok
[ ] If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
[ ] If feature, test running new feature, try creative ways to break it
[ ] CI status: all green or justified

kbenne commented 5 months ago

I think we might get some new failures from ctest as a result of this. (which is a feature not a bug of course)

jmarrec commented 5 months ago

Hummmm I no longer have any minitest output.

test_minitest.rb

require 'minitest'
require 'minitest/autorun'

class MyTest < Minitest::Test
  def test_fail
    assert 0 == 1
  end
end

wenyikuang commented 5 months ago

Eventually I need build the binary from scratch so its not a big difference.

jmarrec commented 5 months ago

I'd say wait, I have some issues with it. Maybe it'll go in RC2.

e52af4dcfc5a5781df68e96ed3b4dc3ad13b9c75 kinda fixes it, but I don't like it one bit

Minitest failures still end up exiting with an exitcode = 0 obviously...

ci-commercialbuildings commented 5 months ago

CI Results for 3b70376ba8ec9bbaefc1abfc097e1bce75773ef5: