NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
484 stars 185 forks source link

measure.xml default bool values reported as 0/1 on develop #5167

Closed jmarrec closed 2 months ago

jmarrec commented 2 months ago

Issue overview

@shorowit reported

I recently updated an OS measure using this build from 5 days ago and it changed all the boolean default values in the measure.xml from false/true to 0/1. (edited)

Current Behavior

it's now 0/1

Expected Behavior

Should be true, not 1.

Steps to Reproduce

1. 2. 3. 4.

Possible Solution

I removed the std::boolapha in https://github.com/NREL/OpenStudio/pull/5142/files#diff-1ce00edad4729733f34a2d1711e926e7d1d09f6ff94bae92e201b7ca3bcef23fR969

Details

Environment

Some additional details about your environment for this issue (if relevant):

Context