v3.8.0-rc1 suffers pollution of environment variables related to bundler

NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.

https://www.openstudio.net/

Other

496 stars 190 forks source link

v3.8.0-rc1 suffers pollution of environment variables related to bundler #5175

Closed kbenne closed 5 months ago

kbenne commented 5 months ago

container image dev-3.8.0-rc1

rm -f Gemfile.lock && bundle install bundle exec rake workflow:analysis_tests

which calls a ruby test file: https://github.com/NREL/resstock/blob/os380/test/test_run_analysis.rb
each test in that file calls openstudio workflow/run_analysis.rb: https://github.com/NREL/resstock/blob/os380/workflow/run_analysis.rb
run_analysis.rb calls openstudio run -w in.osw: https://github.com/NREL/resstock/blob/os380/resources/buildstock.rb#L453-L458

kbenne commented 5 months ago

@joseph-robertson would you be able to test this commit?

kbenne commented 5 months ago

The issue here was that bundler baked into the CLI was picking up on gems installed by (an external) bundler, due to environment variables set by bundle exec rake. OS CLI nulls the environment variables, but it was happening too late.