NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
484 stars 185 forks source link

Fix tests #5184

Closed jmarrec closed 2 months ago

jmarrec commented 2 months ago

Pull request overview

Fixup failing tests on develop after the merge festival

Pull Request Author

Labels:

Review Checklist

This will not be exhaustively relevant to every PR.

ci-commercialbuildings commented 2 months ago

CI Results for 05ca3f67a572072b263119232f78138574b86e2f:

jmarrec commented 2 months ago

The tests are passing on my mac. I think the issue is that the runner doesn't have ruby 3.2.2 activated with bundler installed when it tries to run the tests that match -R CLITest-test_bundle. @wenyikuang

ctest -R CLITest-test_bundle
Test project /Users/julien/Software/Others/OS-build-release
    Start 3894: CLITest-test_bundle-bundle
1/7 Test #3894: CLITest-test_bundle-bundle ...................   Passed    9.02 sec
    Start 3895: CLITest-test_bundle-bundle_git
2/7 Test #3895: CLITest-test_bundle-bundle_git ...............   Passed   10.66 sec
    Start 3896: CLITest-test_bundle-bundle_native
3/7 Test #3896: CLITest-test_bundle-bundle_native ............   Passed    6.66 sec
    Start 3897: CLITest-test_bundle-bundle_native_embedded
4/7 Test #3897: CLITest-test_bundle-bundle_native_embedded ...   Passed    9.97 sec
    Start 3898: CLITest-test_bundle-bundle_no_install
5/7 Test #3898: CLITest-test_bundle-bundle_no_install ........   Passed    6.89 sec
    Start 3899: CLITest-test_bundle-no_bundle
6/7 Test #3899: CLITest-test_bundle-no_bundle ................   Passed    7.89 sec
    Start 3900: CLITest-test_bundle-bundle_default
7/7 Test #3900: CLITest-test_bundle-bundle_default ...........   Passed    7.88 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) =  59.10 sec
$ ruby --version
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin23]

$ bundle --version
Bundler version 2.4.10

$ gem info bundler

*** LOCAL GEMS ***

bundler (2.5.5, 2.4.10, 2.1.4)
    Authors: André Arko, Samuel Giddins, Colby Swandale, Hiroshi
    Shibata, David Rodríguez, Grey Baker, Stephanie Morillo, Chris
    Morris, James Wen, Tim Moore, André Medeiros, Jessica Lynn Suttles,
    Terence Lee, Carl Lerche, Yehuda Katz
    Homepage: https://bundler.io
    License: MIT
    Installed at (default): /Users/julien/.rvm/rubies/ruby-3.2.2/lib/ruby/gems/3.2.0

    The best way to manage your application's dependencies
wenyikuang commented 2 months ago

Yeah, I am pushing the new cmake docker image comes with ruby3.

wenyikuang commented 2 months ago

Running (https://ci.openstudio.net/blue/organizations/jenkins/openstudio-incremental-ubuntu-20-04/detail/PR-5184/6/pipeline/49/) , need to update the CONAN_HOME in my docker image to /root/ to align with other docker images tomorrow.

wenyikuang commented 2 months ago

Updated the image in the master after we merge the PR. Now all them should be align with the local environments.