Closed jmarrec closed 1 month ago
Did a quick test with ruby and it works correctly. Thanks, @jmarrec!
Can we remove this too? https://github.com/NREL/OpenStudio/blob/develop/src/cli/RunCommand.cpp#L37
Integer was broken after that quick fix.
Ok I see I got tripped up by reading a probably EXTREMELY outdated documentation for Json::Value (yeah, it's from 0.5.0...)
https://jsoncpp.sourceforge.net/class_json_1_1_value.html#ec4f74ef7b776b1d9c8a10fc3bb4add5
This commit from cough 13 years ago (json 0.7.0) changed the behavior
https://github.com/open-source-parsers/jsoncpp/commit/1b138e8544d87f8bc4b35214be9f2bdcf78d1f36
CI Results for c05003a002a12e578ece68d41cac574c3313bcd0:
Ubuntu 20.04:
Ubuntu 22.04:
Darwin:
Windows:
Code Coverage:
Pull request overview
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.