NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
484 stars 185 forks source link

Pin regexp_parser to 2.9.0 #5204

Closed jmarrec closed 1 month ago

jmarrec commented 1 month ago

Pull request overview

uses https://github.com/NREL/openstudio-gems/releases/tag/v3.8.0-RC3-2

$ Products/openstudio -e "require 'rubocop/rake_task'; require 'stringio'; RuboCop::RakeTask.new(:rubocop) do |t| t.options = ['--autocorrect', '--format', 'simple', '--only', 'Lint/SelfAssignment'] end; Rake.application[:rubocop].invoke"
Running RuboCop...

Pull Request Author

Labels:

Review Checklist

This will not be exhaustively relevant to every PR.

wenyikuang commented 1 month ago

We could merge it once the arm64_linux os-gems get ready.

jmarrec commented 1 month ago

I've just wiped the CI build dirs so that it's clean and rules out issues that could explain why we have bundle tests failing right now (including on ubuntu 20.04, while it passes on my machine...)

jmarrec commented 1 month ago

3903: Source locally installed gems is ignoring # because it is missing extensions

ci-commercialbuildings commented 1 month ago

CI Results for 49cf80c633861c78144403a32c61ec04743820e5: