NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
484 stars 185 forks source link

Conan ruby: Windows build no longer works on Windows2022 github runner #5223

Open jmarrec opened 2 weeks ago

jmarrec commented 2 weeks ago

Issue overview

Reported by @macumber at:

Filed on the conan-recipes repo at:

https://github.com/jmarrec/conan-recipes/issues/9

Current Behavior

After update to Windows2022 github runner, https://github.com/actions/runner-images/commit/a615999e85d5b3f3853c691cd59fcfe89f0495ae#diff-d3119a278ce9ce80fc4b5af63a1112fb3a044aec3e6002d838e8eb26d7a3a499L223, the MSC_VER is no longer compatible with that in the conan ruby recipe ruby9af7e8c0a7cea\p\include\ruby-3.2.0\x64-mswin64_140\ruby\config.h

#if (_MSC_VER < 1920) || (_MSC_VER > 1939)
#error MSC version unmatch: 1920..1939 is expected.
#endif

I think Ruby is overly restrictive here and the right thing to do is probably patch it to remove this error

Expected Behavior

Steps to Reproduce

1. 2. 3. 4.

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

Context