Closed jmarrec closed 2 weeks ago
@jmarrec I have the fix for the build failing when building the test. Do you want me to push it here?
@TShapinsky In the interest of efficiency, please always assume that is fine if I'm not on slack and it's nighttime in France and it's a quick fix (if you touch 1000s of lines, a PR pointing to the PR like you did is better). I can always revert back or adjust if not.
In this specific case, a code suggestion (since I did touch these lines) would have worked too.
CI Results for c6666556c9d6e0087638e9e41d59212773a06c68:
Ubuntu 24.04:
Ubuntu 22.04:
Darwin:
Windows:
Code Coverage:
Pull request overview
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.