NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
506 stars 192 forks source link

Try to fix Broken C# bindings workflow due to Alfalfa addition #5291

Closed jmarrec closed 2 weeks ago

jmarrec commented 2 weeks ago

Pull request overview

Pull Request Author

Labels:

Review Checklist

This will not be exhaustively relevant to every PR.

TShapinsky commented 2 weeks ago

@jmarrec I have the fix for the build failing when building the test. Do you want me to push it here?

jmarrec commented 2 weeks ago

@TShapinsky In the interest of efficiency, please always assume that is fine if I'm not on slack and it's nighttime in France and it's a quick fix (if you touch 1000s of lines, a PR pointing to the PR like you did is better). I can always revert back or adjust if not.

In this specific case, a code suggestion (since I did touch these lines) would have worked too.

ci-commercialbuildings commented 2 weeks ago

CI Results for c6666556c9d6e0087638e9e41d59212773a06c68: