search

NREL / OpenStudio

OpenStudio is a cross-platform collection of software tools to support whole building energy modeling using EnergyPlus and advanced daylight analysis using Radiance.
https://www.openstudio.net/
Other
494 stars 188 forks source link

Cannot make Compressor Rated Superheat or Rated Return Gas Temp Blank #945

Closed asparke2 closed 6 years ago

asparke2 commented 10 years ago

In the inspector, you cannot make the fields Rated Superheat or Rated Return Gas Temp in a Refrigeration Compressor blank. One or the other of these fields must be blank or EnergyPlus throws severe errors. The only way to fix is to go into the .osm with a text editor.

@kbenne is this caused by error in idd?

mbadams5 commented 10 years ago

@asparke2 No this is not caused by an error in the IDD. The issue is that there is no way to 'reset' a field through the GUI. I am trying to track down a solution.

kbenne commented 10 years ago

screen shot 2014-03-27 at 9 17 38 am

the object in the library appears to be setup for RateReturnGasTemperature and has the RatedSuperheat field blank. I created an idf and tested that the translator doesn't do anything to mess this up. So that should work.

But how do we support RatedSuperheat method? I suggest adding another variation in the library. Of course people can mess that up be entering a value in RatedReturnGasTemperature, but I think we have to live with that until we have a better IG. (Which grid view might become)

mbadams5 commented 10 years ago

This same issue also affects 'Rated Liquid Temperature' and 'Rated Subcooling' in the exact same way within Refrigeration Compressor.

asparke2 commented 10 years ago

@kbenne @mbadams5 I think that the temporary fix of adding a variant to the library is fine. It is much better than not being able to do it at all, and it is probably low risk. Probably another good illustration of why the Inspector needs to be replaced eventually.

kbenne commented 10 years ago

Do we know what a good Rated Superheat value is for our library?

kbenne commented 10 years ago

FYI for everyone. @mbadams5 and I determined that this line is really the trouble.

https://github.com/NREL/OpenStudio/blob/develop/openstudiocore/src/model_editor/InspectorGadget.cpp#L621

way too much risk to deal with now though.

asparke2 commented 10 years ago

@kbenne Go with 40 delta-F (put the number 22.2 in the .osm)

mbadams5 commented 10 years ago

@kbenne @asparke2

@frickeba told me to use 5.56 K or (10 delta-F)

kbenne commented 10 years ago

https://github.com/NREL/OpenStudio/commit/ef9fc8ee34cf6e3d2f1a67751e450a5a161c86fe

will address this issue for now.

DavidGoldwasser commented 9 years ago

@kbenne is this still valid? If so any changes needed for 1.9.0?

evanweaver commented 6 years ago

Fixed via adding variants to library.