search

NREL / PVDegradationTools

Set of tools to calculate degradation responses and degradation related parameters for PV.
https://pvdegradationtools.readthedocs.io/
Other
24 stars 6 forks source link

Versioning #103

Open tobin-ford opened 1 month ago

tobin-ford commented 1 month ago

PVLib V0.11.0 Breaking LETID Tests

To Reproduce install pvlib=0.11.0 and numpy=2.0.0, python=3.9.19

Expected behavior test_calc_injection_outdoors fails due to different values in the check (nan at 88 when it should not have been, following values are slightly different. pvlib=0.10.3 and numpy=1.26.4 fix the issue.

Screenshots https://github.com/NREL/PVDegradationTools/pull/97#issuecomment-2200755120 - screenshot here

Desktop (please complete the following information):

SciPy 1.14.0 Breaking Tests

To Reproduce install scipy=1.14.0 and run tests. python=3.9.19

Expected behavior many pvdeg tests will fail because the function signature for scipy.integrate.simpson was changed slightly. Reverting to scipy<1.14.0 fixes the issue.

https://github.com/NREL/PVDegradationTools/pull/97#issuecomment-2218779560 - more info here

Desktop Same as above

tobin-ford commented 1 month ago

105 Fixes this by restricting the versions for numpy, scipy, and pvlib

tobin-ford commented 1 month ago

To unrestrict the package versions we will need to modify the calc_letid_outdoor test. PVLib issues made the result vary slightly and cause the test to fail.

It would be wise to stay up to date on dependencies.