search

NREL / PVDegradationTools

Set of tools to calculate degradation responses and degradation related parameters for PV.
https://pvdegradationtools.readthedocs.io/
Other
24 stars 5 forks source link

Kempe standoff #43

Closed MDKempe closed 7 months ago

MDKempe commented 7 months ago

Hi Martin, I'm at a point where I want to add this to the main. Hopefully I am doing this correctly.

martin-springer commented 7 months ago

Hi Martin, I'm at a point where I want to add this to the main. Hopefully I am doing this correctly.

We'll add it to development first. To do that, we need to get the tests working.

MDKempe commented 7 months ago

Martin, this time I went through and made sure all the pytests work. It should be ready to commit now. However, I do not believe that all the other programs have sufficient tests and there will be issues. Primarily we need to look for the usage of the variable "wind_speed_factor" with a default of 1.7. That needs to be changed to "wind_factor" with a default of 0.33.

martin-springer commented 7 months ago

is there a reason why the tests/data/h5_pytest.h5 was changed compared to the main branch?