search

NREL / PVDegradationTools

Set of tools to calculate degradation responses and degradation related parameters for PV.
https://pvdegradationtools.readthedocs.io/
Other
31 stars 7 forks source link

Kempe standoff pull request #58

Closed martin-springer closed 9 months ago

martin-springer commented 9 months ago

I'm creating this pull request to pull in code that is ready to be included. Code snippets like in utilities are now on the Kempe_standoff_dev branch

martin-springer commented 9 months ago

@MDKempe - This PR is now ready to be merged into development.

-) I excluded the changes in utitlities.py - You can still find those in a new branch called Kempe_standoff_dev -) I ran pre-commit hooks that took care of some formatting issues https://pre-commit.com/ -) I aligned the wind height variable with NSRDB naming convention -) I refactored eff_gap_parameters() to better align with the logic of the other functions and updated its usage in the Jupyter notebook

All tests are now passing with all the different python versions. Please review my changes and let me know if you'd like certain revisions differently. Thank you!

martin-springer commented 9 months ago

A few unsolicited comments from the peanut gallery regarding the temperature models

Thank you @kandersolar. Every input is very much appreciated!

codecov-commenter commented 9 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella: