search

NREL / PVDegradationTools

Set of tools to calculate degradation responses and degradation related parameters for PV.
https://pvdegradationtools.readthedocs.io/
Other
23 stars 5 forks source link

Monte Carlo PR #62

Closed tobin-ford closed 5 months ago

tobin-ford commented 5 months ago

Added edge case coverage. Will need to update MC - standoff tutorial after merge with development to reflect kempe's standoff function changes.

codecov-commenter commented 5 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (b4e8c43) 44.22% compared to head (2ff2b3d) 47.72%. Report is 10 commits behind head on development.

Files Patch % Lines
pvdeg/degradation.py 23.07% 10 Missing :warning:
pvdeg/montecarlo.py 95.78% 4 Missing :warning:
pvdeg/temperature.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #62 +/- ## =============================================== + Coverage 44.22% 47.72% +3.49% =============================================== Files 26 28 +2 Lines 1662 1800 +138 =============================================== + Hits 735 859 +124 - Misses 927 941 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martin-springer commented 5 months ago

@tobin-ford - The development branch was merged into the Monte Carlo branch. You should be able to update the notebooks now before we merge the PR.

tobin-ford commented 5 months ago

Notebooks modified and unit tests updated. Should be done.