NREL / PVDegradationTools

Set of tools to calculate degradation responses and degradation related parameters for PV.
https://pvdegradationtools.readthedocs.io/
Other
23 stars 5 forks source link

Update weather.py #67

Closed MDKempe closed 5 months ago

MDKempe commented 5 months ago

I had been using the meta information from "Source" to add meta information about the wind speed height but didn't realize that the meta information is not the same for all locations and this was causing crashing. I changed it to use the initial function call variable "database" to determine the source and the wind speed height.

Describe your changes

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist before requesting a review

codecov-commenter commented 5 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (afe636e) 47.72% compared to head (fd1e903) 47.69%.

Files Patch % Lines
pvdeg/weather.py 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #67 +/- ## =============================================== - Coverage 47.72% 47.69% -0.03% =============================================== Files 28 28 Lines 1800 1801 +1 =============================================== Hits 859 859 - Misses 941 942 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.