weather.get() bug fix PR - Githubissues

NREL / PVDegradationTools

Set of tools to calculate degradation responses and degradation related parameters for PV.

https://pvdegradationtools.readthedocs.io/

Other

31 stars 7 forks source link

weather.get() bug fix PR #84

Closed tobin-ford closed 7 months ago

tobin-ford commented 7 months ago

Describe your changes

Restored the META_MAP dictionary in weather.get()

Fixes: Value Error from undefined variable inside weather,get()

To reproduce: run the following code on development branch

weather_db = 'PSM3'
weather_id = (25.783388, -80.189029)
weather_arg = {'api_key': 'DEMO_KEY',
               'email': 'user@mail.com',
               'names': 'tmy',
               'attributes': [],
               'map_variables': True}

weather_df, meta = pvdeg.weather.get(weather_db, weather_id, **weather_arg)

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] Code changes are covered by tests.
[x] Example notebooks are rerun and differences in results scrutinized

tobin-ford commented 7 months ago

Highlights the need for more testing. get() does not have any pytests currently as they are commented out?