NREL / PVDegradationTools

Set of tools to calculate degradation responses and degradation related parameters for PV.
https://pvdegradationtools.readthedocs.io/
Other
31 stars 7 forks source link

Kempe gap calc #95

Closed MDKempe closed 3 months ago

MDKempe commented 5 months ago

These changes are inconsequential so anyone can approve. Fixed a function call to use "poa_global" and some integer/float variable type designation, and an issue with using temperature.temperature instead of temperature.cell.

tobin-ford commented 5 months ago

This adds all of my scenario changes to development which we aren't ready for yet because we merged dev_geospatial_scenario -> Kempe_Gap_Calc earlier instead of updating the tutorial on dev_geospatial_scenario.

Probably best to hold off on this or change scope.

martin-springer commented 5 months ago

Yeah, we want to wait with those until the scenario analysis is ready. @MDKempe - if your changes are not associated with the scenario analysis, pull them into another branch that doesn't have those changes in it and we can move them forward.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 44.69697% with 584 lines in your changes missing coverage. Please review.

Project coverage is 62.47%. Comparing base (57cb222) to head (679e347).

Files Patch % Lines
pvdeg/scenario.py 31.38% 341 Missing :warning:
pvdeg/geospatial.py 11.71% 113 Missing :warning:
pvdeg/utilities.py 28.76% 104 Missing :warning:
pvdeg/weather.py 22.22% 21 Missing :warning:
pvdeg/standards.py 71.42% 2 Missing :warning:
pvdeg/temperature.py 96.77% 2 Missing :warning:
pvdeg/degradation.py 94.44% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #95 +/- ## =============================================== - Coverage 67.02% 62.47% -4.56% =============================================== Files 29 30 +1 Lines 2111 3046 +935 =============================================== + Hits 1415 1903 +488 - Misses 696 1143 +447 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tobin-ford commented 4 months ago

Added the plotting for the region standoff calculation in the IEC 63126 tool that Mike and I talked about last week.