Closed MDKempe closed 1 month ago
tobin-ford
commented
4 months ago This adds all of my scenario changes to development which we aren't ready for yet because we merged dev_geospatial_scenario -> Kempe_Gap_Calc earlier instead of updating the tutorial on dev_geospatial_scenario.
Probably best to hold off on this or change scope.
martin-springer
commented
4 months ago Yeah, we want to wait with those until the scenario analysis is ready. @MDKempe - if your changes are not associated with the scenario analysis, pull them into another branch that doesn't have those changes in it and we can move them forward.
codecov-commenter
commented
3 months ago Attention: Patch coverage is 44.69697% with 584 lines in your changes missing coverage. Please review.
Project coverage is 62.47%. Comparing base (
57cb222) to head (679e347).
| Files | Patch % | Lines |
|---|---|---|
| pvdeg/scenario.py | 31.38% | 341 Missing :warning: |
| pvdeg/geospatial.py | 11.71% | 113 Missing :warning: |
| pvdeg/utilities.py | 28.76% | 104 Missing :warning: |
| pvdeg/weather.py | 22.22% | 21 Missing :warning: |
| pvdeg/standards.py | 71.42% | 2 Missing :warning: |
| pvdeg/temperature.py | 96.77% | 2 Missing :warning: |
| pvdeg/degradation.py | 94.44% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
tobin-ford
commented
2 months ago Added the plotting for the region standoff calculation in the IEC 63126 tool that Mike and I talked about last week.
These changes are inconsequential so anyone can approve. Fixed a function call to use "poa_global" and some integer/float variable type designation, and an issue with using temperature.temperature instead of temperature.cell.