Dev scenario geospatial

tobin-ford commented 3 months ago

Describe your changes

Initial Scenario Analysis Integration. Sweeping scenario changes. New temperature function temperature.temperature that combines all temperature calculations (cell and module) into one function with support for all pvlib temperature models. All pvdeg functions preforming temperature calculations have been updated accordingly.

Additionally

Unified Cell and Module Temperature function. See: `temperature.temperature``
Added support for pvlib temperature models. see pvlib docs <https://pvlib-python.readthedocs.io/en/stable/reference/pv_modeling/temperature.html>
Overhauled scenario class for pv system analysis. Scenario object for single point analysis and GeospatialScenario object for geospatial analysis. See: scenario.Scenario and scenario.GeospatialScenario
Created Scenario tutorials to showcase new scenario functionality.
Added a number of geospatial downselection functions. Find coordinates near mountains, rivers, coastlines and lakes from NSRDB data. See: geospatial.identify_mountains_weights, geospatial.identify_mountains_radii, geospatial.feature_downselect
Added geospatial bounding box support. Clip unwanted data with rectangular bounding boxes. See: geospatial.apply_bounding_box
Added stochastic non-uniform density downselection function to preferentially select for mountains (higher point density with changes in elevation, lower density when flatter.) See: geospatial.elevation_stochastic_downselection
Updated non-uniform downselection with thresholding and non-linear normalization (support for logarithmic and exponential normalization) See: geospatial.identify_mountains_weights
Added Scenario and GeospatialScenario methods for quick plotting and downselection. See: GeospatialScenario.plot_coords, GeospatialScenario.plot_meta_classification GeospatialScenario.plot_USA, Scenario.extract, Scenario.plot, GeospatialScenario.classify_mountain_weights, GeospatialScenario.classify_mountain_radii, GeospatialScenario.downselect_elevation_stochastic

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] Code changes are covered by tests.
[x] New functions added to init.py
[x] API.rst is up to date, along with other sphinx docs pages
[x] Example notebooks are rerun and differences in results scrutinized
[x] What's new changelog has been updated in the docs

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 45.34884% with 564 lines in your changes missing coverage. Please review.

Project coverage is 62.83%. Comparing base (57cb222) to head (5e5d514).

Files	Patch %	Lines
pvdeg/scenario.py	31.38%	341 Missing :warning:
pvdeg/geospatial.py	11.71%	113 Missing :warning:
pvdeg/utilities.py	28.76%	104 Missing :warning:
pvdeg/standards.py	71.42%	2 Missing :warning:
pvdeg/temperature.py	96.77%	2 Missing :warning:
pvdeg/degradation.py	94.44%	1 Missing :warning:
pvdeg/weather.py	66.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## development #97 +/- ## =============================================== - Coverage 67.02% 62.83% -4.20% =============================================== Files 29 30 +1 Lines 2111 3024 +913 =============================================== + Hits 1415 1900 +485 - Misses 696 1124 +428 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tobin-ford commented 3 months ago

Not sure if we've run into this before @martin-springer

Pvlib=0.11.0 appears to be problematic. As installed on a local environment with python=3.9.19 and numpy=2.0.0 it caused test_calc_injection_outdoors to fail. The test failes because the series values are similar to the saved values but slightly different. index=88 was NaN when it should not have been but a plot of the series reveals that the series are very similar anyways. This could just be an implementation change/update in the newer pvlib versions. This is caused by the effective irradiance from the modelchain instance being varying across these versions which is then used in the subsequent test calculation. Orange are test calculated values and blue is stored test values.

When running with pvlib=0.10.3 and numpy=1.26.4 it will pass the test on python=3.9.19. This may be indicative of some other issues but we should restrict the github automations to using a working pvlib version.

Note: we could also upgrade the pvlib version and change the test check values.

Edit: Pvlib 0.11.0 released on June 21, 2024, which was after the last test passed on commit be577c2 (over 2 weeks ago) so if we are always using the most recent version we should apply the change i mentioned above ^

Edit: this appears to be the only test affected by the pvlib version so it would make sense to update the stored testing values rather than restricting ourselves to an older pvlib version.

tobin-ford commented 2 months ago

Dependency versioning issue again. This might be better as its own PR as it will affect all users with the newest scipy version.

`scipy 1.14.0` changed the function signatures for many of the quadrature integration functions.

scipy < 1.14.0: scipy.integrate.simpson(y, *, x=None, dx=1.0, axis=-1, even=<object object>)[source]

scipy 1.14.0 simpson(y, *, x=None, dx=1.0, axis=-1)[source]

Edit: My changes seem to have not propagated correctly during the testing. My branch is synced with the head and passes locally.

NREL / PVDegradationTools