Closed kandersolar closed 3 years ago
@kperrynrel I also configured RTD to do unofficial PR builds as another CI check; here's the one for this PR: https://panel-segmentation--4.org.readthedocs.build/en/4/index.html
Between the fixes here and in #1, most of the rendering issues are fixed at this point. There are a few build warnings that would be nice to fix but don't affect the rendered docs, so I might follow this up with another PR for those and some additional minor cleanup.
What do you think about integrating your example notebooks into the sphinx docs? It's pretty easy to use notebooks as the source code for pages like this rdtools example page, and I recently discovered you can create an example gallery from notebooks too like this test PR for rdtools. Happy to add that here if you think that's a good idea.
@kanderso this looks great. I requested a review--I'm gonna try a pip install on this, and troubleshoot if we have any issues on running the jupyter notebooks. Thank you so much for your help!
Tested package with pip install in a fresh conda environment. Looks good, merging this.
Using the same (questionable) package dependencies from #3 here just so that the package installs successfully on RTD.
I'm configuring
latest
to track master andstable
to track the latest non-pre-release tag, withstable
being the default.