NREL / REopt-Analysis-Scripts

BSD 3-Clause "New" or "Revised" License
34 stars 35 forks source link

Load adjustment not changing results #100

Closed ewhite58 closed 1 year ago

ewhite58 commented 1 year ago

Discussed in https://github.com/NREL/REopt-API-Analysis/discussions/99

Originally posted by **ewhite58** February 15, 2023 Every time I adjust the load (increase to 115% or 150%) in the load profile section of a run in REopt, it doesn't change the results (cost, sizing of PVs/batteries). I can't find anything in the user manual that reflects the newer version of REopt - can anyone help?
ewhite58 commented 1 year ago

I figured it out - whatever you upload as your custom load profile is seen as the adjusted load by the tool. For example, say the load I’m inputting is 100 kWh. If I change the load adjustment in the tool to 75%, then the original load would be 133.3 kWh, and adjusted would be 100 kWh. If I change the load adjustment in the tool to 125%, then the original load would be 80 kWh, and adjusted would be 100 kWh.

adfarth commented 1 year ago

I figured it out - whatever you upload as your custom load profile is seen as the adjusted load by the tool. For example, say the load I’m inputting is 100 kWh. If I change the load adjustment in the tool to 75%, then the original load would be 133.3 kWh, and adjusted would be 100 kWh. If I change the load adjustment in the tool to 125%, then the original load would be 80 kWh, and adjusted would be 100 kWh.

Hello, apologies for the delayed response. Our UI developers have discovered a bug with the custom load profiles and the load adjustment slider. The bug occurs when the profile is uploaded, and then the slider is adjusted (as opposed to vice versa). We are now working to address this and will update here when the fix is complete. Thank you very much for drawing our attention to this and apologies for the inconvenience!

adfarth commented 1 year ago

Hello, we have identified and now fixed a bug in the web tool in which the load adjustment slider bar was incorrectly adjusting a custom load profile. The slider bar should now work as expected (multiply the custom load in each timestep by XXX%). Apologies for the inconvenience and thank you for bringing this to our attention!

ewhite58 commented 1 year ago

Hello,

Thank you so much for looking into this, and for fixing the tool!

On Fri, Mar 3, 2023 at 10:13 AM adfarth @.***> wrote:

Hello, we have identified and now fixed a bug in the web tool in which the load adjustment slider bar was incorrectly adjusting a custom load profile. The slider bar should now work as expected (multiply the custom load in each timestep by XXX%). Apologies for the inconvenience and thank you for bringing this to our attention!

— Reply to this email directly, view it on GitHub https://github.com/NREL/REopt-API-Analysis/issues/100#issuecomment-1453678343, or unsubscribe https://github.com/notifications/unsubscribe-auth/A55LDGIVFPE6BJK5S77SFFDW2IDADANCNFSM6AAAAAAVCAWTMU . You are receiving this because you modified the open/close state.Message ID: @.***>