search

NREL / REopt-Analysis-Scripts

BSD 3-Clause "New" or "Revised" License
34 stars 35 forks source link

Updates #50

Closed Bill-Becker closed 3 years ago

Bill-Becker commented 3 years ago
  1. Add dockerized environment for Python using Jupter Lab
  2. Remove the Binder notebook
  3. Separate single- and multi- scenario into two notebooks
  4. Remove duplicative /src and file structures (previously in "notebook" and "examples" directories), so there's just a single level with src, inputs, outputs, etc directories and two jupyter notebooks that use those
NLaws commented 3 years ago

@Bill-Becker could you please check the format of your requirements.txt locally and try pushing up a text version? It is showing up as binary in this repo and so can't be displayed.

NLaws commented 3 years ago

Also on requirements.txt, I was able to read it after pulling your branch, but it appears to have some issues:

ERROR: Could not find a version that satisfies the requirement pywin32==302 (from -r requirements.txt (line 57)) (from versions: none)
ERROR: No matching distribution found for pywin32==302 (from -r requirements.txt (line 57))

Maybe we can remove pywin32?

Also, the README.md says that the "requirements.txt does not include dependencies for the jupyter > notebooks" but notebook is in the requirements.txt so maybe that NOTE is no longer true? I also got a warning when installing the requirements about nbformat:

WARNING: The candidate selected for download or install is a yanked version: 'nbformat' candidate
Bill-Becker commented 3 years ago

@NLaws The comment about the requirements.txt not having the packages needed for the notebook was referring to one of the two requirements.txt files that used to be in here. There was also one in the /examples directory (gone now) that did have the Notebook package. Looks like you did not include the Notebook package in the re-built requirements.txt, so that statement becomes true again. I was thinking about adding it back in. Any issues with that?

Bill-Becker commented 3 years ago

@NLaws The comment about the requirements.txt not having the packages needed for the notebook was referring to one of the two requirements.txt files that used to be in here. There was also one in the /examples directory (gone now) that did have the Notebook package. Looks like you did not include the Notebook package in the re-built requirements.txt, so that statement becomes true again. I was thinking about adding it back in. Any issues with that?

NEVERMIND - I think the Jupyter Notebook/Lab setup should be outside/independent of this environment because there's different preferences and ways to do it. Also, it's a much larger set of packages.