Use Parameters.jl to ease maintenance of parameter struct

NREL / REopt_API

The model for the REopt API, which is used as the back-end for the REopt Webtool (reopt.nrel.gov/tool), and can be accessed directly via the NREL Developer Network (https://developer.nrel.gov/docs/energy-optimization/reopt)

https://developer.nrel.gov/docs/energy-optimization/reopt

Other

87 stars 46 forks source link

Use Parameters.jl to ease maintenance of parameter struct #37

Closed jmpohl closed 4 years ago

jmpohl commented 4 years ago

I'm submitting a ...
- [x] feature request

I have been adding fields to the Parameter struct in reo/src/utils.jl and have found it cumbersome to have to reorder the arguments of the Parameter constructor every time I move things around in the struct definition. Turns out Parameters.jl is made for just such a use case and comes with some nice additional functionality that might simplify upstream code. I'll give it a look when I have more free time

NLaws commented 4 years ago

@jmpohl Would Base.@kwdef address this issue? Then we don't have to add Parameters.jl to dependencies.

NLaws commented 4 years ago

This issue was addressed with https://github.com/NREL/REopt_Lite_API/pull/53 and https://github.com/NREL/REopt_Lite_API/pull/54