Updating Test_Cases/InflowFile input files

Yuksel-Rudy commented 1 year ago

Description and Purpose

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

TODO Items General:

[ ] Add example/test for new feature
[ ] Update registry
[ ] Run testing

TODO Items API Change:

[ ] Update docs with API change
[ ] Run update_rosco_discons.py in Test_Cases/
[ ] Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

dzalkind commented 1 year ago

Hi Rudy,

Thanks! This is a good start. Can you merge in the develop branch? That's where we'd like to merge this.

If you're okay with it, I can make edits on my end. It's easy to update the CI so it uses OpenFAST 3.5.0, but we'll still need to update the OpenFAST readers/writers to make it all work.

Best, Dan

Yuksel-Rudy commented 1 year ago

That sounds perfect. I’m planning on editing more as I go.

Also, I have a local repo that I’m using for my DigiTWind application. Do we want that to go eventually into the dev branch or shall we make another branch just to experiment with it?

On Thu, May 25, 2023 at 2:44 PM dzalkind @.***> wrote:

Hi Rudy,

Thanks! This is a good start. Can you merge in the develop branch? That's where we'd like to merge this.

If you're okay with it, I can make edits on my end. It's easy to update the CI so it uses OpenFAST 3.5.0, but we'll still need to update the OpenFAST readers/writers to make it all work.

Best, Dan

— Reply to this email directly, view it on GitHub https://github.com/NREL/ROSCO/pull/244#issuecomment-1563347358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZRN3T5EFLGHKBWTWWAYPCLXH6R7DANCNFSM6AAAAAAYPF4IAU . You are receiving this because you authored the thread.Message ID: @.***>

-- Yüksel Ruwad Alkarem (Rudy) Ph.D. Student and Graduate Research Assistant Civil and Environmental Engineering Advanced Structures & Composites Center University of Maine 108 Boardman Hall Orono, ME 04469 207-561-0092

dzalkind commented 1 year ago

Hi Rudy,

In general, we do merges into the develop branch.

I'd recommend we keep that as a separate repository for now. Anything added here has to be maintained going forward and tested so that it works for others. Let's discuss what parts make sense to add here offline.

Best, Dan

dzalkind commented 1 year ago

Thanks for your contribution here, @Yuksel-Rudy! This PR has been merged with the other one in #246.

NREL / ROSCO