Wrong check for F_NotchType's value

NREL / ROSCO

A Reference Open Source Controller for Wind Turbines

https://rosco.readthedocs.io/en/latest/

Apache License 2.0

116 stars 93 forks source link

Wrong check for F_NotchType's value #247

Closed R-Quancard closed 1 year ago

R-Quancard commented 1 year ago

Hello, I've noticed that mode 3 of F_NotchType could not be used because CheckInputs only allows 0, 1 or 2. Actually, the suitable check is there (allowing 0 to 3) but an additional one blocks the case F_NotchType = 3, so that second one should be removed.

https://github.com/NREL/ROSCO/blob/e3b7db779ad9e7bea5dea692e92f52b10116cf02/ROSCO/src/ReadSetParameters.f90#L735-L745

dzalkind commented 1 year ago

Good catch...thanks!

I have pushed a change to #246.

Best, Dan

dzalkind commented 1 year ago

This should be in the develop branch now.