Fixed-Pitch Torque Control in Region 3 - Githubissues

NREL / ROSCO

A Reference Open Source Controller for Wind Turbines

https://rosco.readthedocs.io/en/latest/

Apache License 2.0

106 stars 92 forks source link

Fixed-Pitch Torque Control in Region 3 #347

Open dstockhouse opened 4 months ago

dstockhouse commented 4 months ago

Description and Purpose

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

TODO Items General:

[ ] Add example/test for new feature
[ ] Update registry
[ ] Run testing

TODO Items API Change:

[ ] Update docs with API change
[ ] Run update_rosco_discons.py in Test_Cases/
[ ] Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

dzalkind commented 4 months ago

Hey David, thanks for the contribution here, it looks great overall! My comments should be pretty easy to address and are mainly aimed at documentation for our later sanity.

dzalkind commented 4 months ago

The DISCONs can be updated automatically with: https://github.com/NREL/ROSCO/blob/main/Examples/Test_Cases/update_rosco_discons.py

dzalkind commented 4 months ago

Can you add a description of the added features to the PR?

dzalkind commented 4 months ago

Can you describe the extra inputs here? https://github.com/NREL/ROSCO/blob/main/docs/source/api_change.rst

dzalkind commented 4 months ago

@dstockhouse, for any API changes to the DISCON, please use the registry as described here: https://github.com/NREL/ROSCO/blob/vbf/docs/source/how_to_contribute_code.rst#updating-the-rosco-api-changing-input-files

Edit: I see that you have...thanks!

dzalkind commented 4 months ago

I'm seeing this model still pitching, probably due to the floating feedback. I'm going to disable the whole pitch controller with PC_ControlMode and then let you finish your work here.

dzalkind commented 4 months ago

Perhaps we leave the torque-speed lookup out of this PR and address it another time. We're already doing a lot here. Let me know what you think.

dzalkind commented 1 month ago

Yeah, there are a lot of outdated comments. Please ignore.