Fixed-Pitch Torque Control in Region 3

[dstockhouse]

Description and Purpose

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (non-backwards-compatible fix or feature)
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no API changes)
• [ ] Documentation update
• [ ] Maintenance update
• [ ] Other (please describe)

TODO Items General:

• [x] Add example/test for new feature
• [ ] Update registry
• [ ] Run testing

TODO Items API Change:

• [ ] Update docs with API change
• [ ] Run update_rosco_discons.py in Test_Cases/
• [ ] Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

[dzalkind]

Hey David, thanks for the contribution here, it looks great overall! My comments should be pretty easy to address and are mainly aimed at documentation for our later sanity.

[dzalkind]

The DISCONs can be updated automatically with: https://github.com/NREL/ROSCO/blob/main/Examples/Test_Cases/update_rosco_discons.py

[dzalkind]

Can you add a description of the added features to the PR?

[dzalkind]

Can you describe the extra inputs here? https://github.com/NREL/ROSCO/blob/main/docs/source/api_change.rst

[dzalkind]

@dstockhouse, for any API changes to the DISCON, please use the registry as described here: https://github.com/NREL/ROSCO/blob/vbf/docs/source/how_to_contribute_code.rst#updating-the-rosco-api-changing-input-files

Edit: I see that you have...thanks!

[dzalkind]

I'm seeing this model still pitching, probably due to the floating feedback. I'm going to disable the whole pitch controller with PC_ControlMode and then let you finish your work here.

[dzalkind]

Perhaps we leave the torque-speed lookup out of this PR and address it another time. We're already doing a lot here. Let me know what you think.

[dzalkind]

Yeah, there are a lot of outdated comments. Please ignore.

[dzalkind]

Hi @dstockhouse, this looks great overall.

I have confirmed that these additions maintain our normal FOWT operation: comp_outputs.pdf

When I run the first controller configuration in the fixed-pitch example, I see:

This doesn't seem to match the schedule for the underspeed configuration. Do you see the same? What do you think is happening here?