search

NREL / ROSCO_toolbox

A repository for generating ROSCO controller input files and more.
http://rosco-toolbox.readthedocs.io/
Apache License 2.0
23 stars 20 forks source link

ROSCO_walkthrough issues #14

Open benoitpaillard opened 4 years ago

benoitpaillard commented 4 years ago

Hi all, I stumbled upon a couple of issues in the Jupyter notebook, I guess it makes sense to report them here.

lib_name = ('../ROSCO/build/libdiscon.dylib') can be replaced by the following to take into account all OS

import glob
lib_name = glob.glob('../ROSCO/build/libdiscon*')[0]

I reckon fast_io.load_outputis now called fast_io.load_FAST_out

Test_Cases/5MW_Turb_NR/5MW_Turb_NR.out and Test_Cases/5MW_Step/5MW_Step.outb do not exist with the raw repo state. It might make sens to run some of the example to create them, if this is robust enough ?

Thanks anyway for the great tool ! Looks very promising with WISDEM

nikhar-abbas commented 4 years ago

Thanks for the comments on this, that all makes perfect sense!

I'm going to leave this issue open until the next version incrementation of the ROSCO toolbox - we'll make sure to incorporate these fixes into the next update.

Nikhar