search

NREL / ROSCO_toolbox

A repository for generating ROSCO controller input files and more.
http://rosco-toolbox.readthedocs.io/
Apache License 2.0
23 stars 20 forks source link

Interpolation bug fixes #40

Closed nikhar-abbas closed 3 years ago

nikhar-abbas commented 3 years ago

This fixes some bugs with the interpolation of Cp and Ct surfaces.

When calculating the the expected pitch angle trajectory, the specifics of the Cp surface can cause a non-monotonic interpolation function. The logic says "For a specific TSR, what is the blade pitch angle that gives a Cp of x". If the Cp's for a specific TSR are not monotonic, errors can be caused. 65c4020 fixes this by only allowing blade pitch angles that occur "above" the maximum Cp for a specific TSR - this provides the expected results.

9e89ef8 sets the Ct surface interpolation to linear instead of cubic - this is giving cleaner results

dzalkind commented 3 years ago

Makes sense. Examples run and look good!