PR fixing/improving ROSCO from RAAW work - Githubissues

NREL / ROSCO_toolbox

A repository for generating ROSCO controller input files and more.

http://rosco-toolbox.readthedocs.io/

Apache License 2.0

23 stars 20 forks source link

PR fixing/improving ROSCO from RAAW work #64

Closed ptrbortolotti closed 2 years ago

ptrbortolotti commented 2 years ago

Description and Purpose

While working on the RAAW controller I ran into a couple roadblocks that I've fixed:

The ranges for TSR and pitch were a little tiny
Example 4 saved the DISCON in the running directory and not in example folder
The min rotor speed wasn't set correctly for gearbox ratios higher than 1
There was a bug in the Cp interpolation

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Github issues addressed, if one exists

Examples/Testing, if applicable