search

NREL / Radiance

This repo has been archived. Please refer to https://github.com/LBNL-ETA/Radiance/tree/master for the latest updates.
Other
166 stars 64 forks source link

More robust version string creation #12

Closed nljones closed 8 years ago

nljones commented 8 years ago

I figured it was time to learn how to do a pull request. Also, here are some changes I've made to the version string automatic creation. Among other things, it prints the date and user for more platforms. It also recognizes that the "\n" in my user name is not supposed to be a new line.

rpg777 commented 8 years ago

Nice, Nathaniel! The problem is, this GitGub repo is but a mirror of the CVS. It's not seamless to merge changes this way (pull requests). What I do is just make a diff/patch of my local changes and email them directly to Greg Ward; he merges them into the CVS, and then those changes are reflected on this mirror within an hour when the bot refreshes the mirror. Sound good?

rpg777 commented 8 years ago

P.S. these updates are most appreciated. I generally edit the Version.c manually, but these changes will make everything play nice across all platforms.

nljones commented 8 years ago

Sounds good. What you do with the code is up to you, after all.

The main idea of this fork is to consolidate the Daysim programs (which are currently stored in multiple versions across no less than four(!) repos, and generally based on 15-year-old versions of Radiance code). Feel free to take what you want from it as it gets assembled, although I'm not sure what the level of demand is for this stuff. It (should) all be open-source under the Daysim licence.

rpg777 commented 8 years ago

Great!